• Adam Klein's avatar
    [parser] Remove inlining of Parser::RewriteSpreads · 1abeb0ca
    Adam Klein authored
    Despite the V8_INLINE annotation, it was never actually inlined until
    18cac20c removed the NonPatternRewriter,
    causing all calls to Parser::RewriteNonPattern() to inline RewriteSpreads.
    
    This patch should recover the binary bloat in the attached bug while
    retaining the inlining of the rest of RewriteNonPattern, which in
    the common case does very little work (and doesn't call out to RewriteSpreads).
    
    Bug: chromium:784924
    Change-Id: I1c2062b41ceb51a9522d49bdb9353e1840393ca1
    Reviewed-on: https://chromium-review.googlesource.com/769442Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49370}
    1abeb0ca
parser.h 47.1 KB