• Tobias Tebbi's avatar
    [csa] check arity when calling · dcfc453e
    Tobias Tebbi authored
    Add information to CallInterfaceDescriptor if additional implicit arguments
    can be passed on the stack, that is, if it is a varargs calling convention.
    
    With this information, we can have a proper DCHECK in CSA to avoid passing
    the wrong number of arguments to builtins that don't support it.
    Previously, this lead to difficult to investigate crashes with misaligned
    stacks.
    
    Drive-by cleanup: Reduce duplication between DEFINE_PARAMETERS_... macros.
    
    Change-Id: I449af6713a3cdd72e098d3481dfee62e01343f14
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1888932Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64666}
    dcfc453e
code-assembler.cc 69.3 KB