• Mythri Alle's avatar
    Revert "Reland "[TurboFan] Don't serialize read-only heap objects"" · 338799cd
    Mythri Alle authored
    This reverts commit a4db68d4.
    
    Reason for revert: Speculatively reverting: failure on win32 bot
    https://ci.chromium.org/p/v8/builders/ci/V8%20Win32%20-%20debug/23495
    Not sure if the test is flaky or this cl is actually making it flaky. Reverting while I investigate this issue.
    
    Original change's description:
    > Reland "[TurboFan] Don't serialize read-only heap objects"
    > 
    > Reland the cl with fixes to TSAN failures.
    > 
    > This reverts commit 03c9de73.
    > 
    > 
    > Original change's description:
    > > Revert "[TurboFan] Don't serialize read-only heap objects"
    > >
    > > This reverts commit 9f18e55f.
    > >
    > > Reason for revert: https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20TSAN/29660
    > >
    > > Original change's description:
    > > > [TurboFan] Don't serialize read-only heap objects
    > > >
    > > > Read-only heap objects are immutable and immovable. It is safe to access
    > > > these objects directly from the heap. Not having to serialize them
    > > > reduces the time we spend on main thread especially for TurboProp.
    > > >
    > > > Bug: v8:9684
    > > > Change-Id: Ibabb7076af50c9007d2a8ed57fe257406958fb6a
    > > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1955596
    > > > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    > > > Reviewed-by: Maya Lekova <mslekova@chromium.org>
    > > > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#65490}
    > >
    > > TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org
    > >
    > > Change-Id: If2d8649cdc083f7d064684352501320a96a1ba2c
    > > No-Presubmit: true
    > > No-Tree-Checks: true
    > > No-Try: true
    > > Bug: v8:9684
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1973732
    > > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > > Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#65492}
    > 
    > TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org,nicohartmann@chromium.org
    > 
    > # Not skipping CQ checks because original CL landed > 1 day ago.
    > 
    > Bug: v8:9684
    > Change-Id: I54c9973d0f4d88504b2fb920feb3480fe1f1e1fc
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1980573
    > Reviewed-by: Mythri Alle <mythria@chromium.org>
    > Reviewed-by: Michael Stanton <mvstanton@chromium.org>
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65584}
    
    TBR=mvstanton@chromium.org,neis@chromium.org,mythria@chromium.org,mslekova@chromium.org,nicohartmann@chromium.org
    
    Change-Id: Ic28774a2530bb7b6688a974f2af4a23ec04ef236
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9684
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1987250Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65585}
    338799cd
js-heap-broker.cc 184 KB