• Benedikt Meurer's avatar
    [debugger] Remove "Restart frame" feature. · 93f85699
    Benedikt Meurer authored
    The "Restart frame" feature was implemented as part of LiveEdit and
    primarily used to support LiveEdit of active functions, but that was
    previously disabled as part of https://crrev.com/c/2846892 because it's
    too brittle and causes crashes when using seemingly unrelated features.
    The "Restart frame" feature was also available as a context menu item
    separately in the DevTools front-end, but that was also already removed
    as part of https://crrev.com/c/2854681 earlier. So all uses are gone
    now.
    
    This change works by marking Debugger.restartFrame as deprecated and
    having it respond with a ServerError all the time. It thus allows us to
    remove a whole bunch of machinery that was essentially just put in
    various places to support the restart_fp_ magic. In particular the
    debugger no longer needs any machine specific builtins now.
    
    Bug: chromium:1195927
    Change-Id: I1153ba6b00e979620af57dd9f58aa1c035ec4484
    Fixed: chromium:1203606
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2854750Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74276}
    93f85699
interpreter-assembler.h 18.8 KB