• Jakob Gruber's avatar
    [compiler] Visit-order-independent inlining heuristics · 2dd02967
    Jakob Gruber authored
    When making inlining decisions in the JSInliningHeuristic, it's
    possible that a Node is not a candidate on the first visit, but
    becomes a candidate in later visits due to other node reductions.
    
    These later visits should also result in the inlining decision being
    made. Until now this was prevented by the visit aborting early since
    the Node was added to the seen_ list on the first (unsuccessful)
    visit.
    
    This CL changes the seen_ insertion to happen only once a positive
    inlining decision was made.
    
    Change-Id: Ide7f6abd3c1d9759d7422fcd5ad9c7daff825795
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2764759
    Auto-Submit: Jakob Gruber <jgruber@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73533}
    2dd02967
js-inlining-heuristic.cc 33 KB