• Ng Zhi An's avatar
    [x64] Fix vroundps assembly, add disassembly · 02ee6904
    Ng Zhi An authored
    vroundps assembly is incorrect:
    - the signature was wrong, vroundps takes 2 operands and 1 immediate
    - when calling vinstr, should always pass xmm0, this wasn't causing
    issues because our test cases were restricted enough that it was always
    xmm0 anyway
    - the macro assembler should use AVX_OP_SSE4_1, since roundps requires
    SSE4_1
    - drive-by fix for roundss and roundsd to be AVX_OP_SSE4_1
    - add disasm for roundps and vroundps, and test them
    
    Bug: v8:10553
    Change-Id: I4046eb81a9f18d5af7137bbd46bfa0478e5a9ab2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227252Reviewed-by: 's avatarDeepti Gandluri <gdeepti@chromium.org>
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68157}
    02ee6904
macro-assembler-x64.h 41.6 KB