• Leszek Swirski's avatar
    Revert "[objects] Change String::length field to uint32_t." · 4bbb7c4e
    Leszek Swirski authored
    This reverts commit 1f1eb625.
    
    Reason for revert: GC Stress failure (https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/21311) 
    
    Original change's description:
    > [objects] Change String::length field to uint32_t.
    > 
    > This changes the Name::hash_field and Symbol::flags to uint32_t as
    > well, so that both Symbols and Strings consume one fewer word on 64-bit
    > architectures now. More importantly the access to String::length is
    > always a 32-bit field load now, even with 31-bit Smis (i.e. on ARM or
    > on 64-bit with pointer compression), so the access should be faster.
    > 
    > Bug: v8:7065, v8:8171
    > Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng
    > Change-Id: I5523deb1f84ece91fa2fea775d50318bd1300493
    > Reviewed-on: https://chromium-review.googlesource.com/1221288
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#55825}
    
    TBR=yangguo@chromium.org,tebbi@chromium.org,ishell@chromium.org,bmeurer@chromium.org
    
    Change-Id: I73f3200902f9d52e5664d48c938e37d9dfb7bce7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7065, v8:8171
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng;luci.v8.try:v8_linux_noi18n_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/1221706Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55826}
    4bbb7c4e
simplified-lowering.cc 157 KB