• Dominik Inführ's avatar
    [heap] Add and remove allocation observers without using safepoints · d79e0c4f
    Dominik Inführ authored
    Safepoints were used in Heap::AddAllocationObserversToAllSpaces and
    Heap::RemoveAllocationObserversFromAllSpaces as a poor man's approach
    to synchronization. This CL removes the safepoint and protects the
    potential race on the free list with a mutex in
    PagedSpace::DecreaseLimit.
    
    The motivation for this CL is that SafepointScope might possibly park
    the main thread in the future. However parking is only allowed if GCs
    are also allowed. GCs are not allowed when running allocation observers,
    so an allocation observer would not be able to add or remove additional
    observers as is currently done in StressConcurrentAllocationObserver.
    
    Also adding additional checks to the safepoint to ensure that we are
    on the main thread.
    
    Bug: v8:11708
    Change-Id: I4e65a83ac4015d30b15d8c4eeaed4ea759b7c982
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3160523
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#76867}
    d79e0c4f
safepoint.cc 5.36 KB