• Mythri A's avatar
    [turboprop] For double data fields check loaded value is HeapNumber · 3551cac6
    Mythri A authored
    With in-place representation changes we can transition from a double
    field to a Tagged field without changing the map. So it is not always
    safe to assume the loaded value would be a HeapNumber. TurboFan takes a
    dependency on the field representation to ensure the code is deoptimized
    on any changes. With dynamic map checks, it is not possible to take such
    a dependency. Hence check the loaded value is a HeapNumber and
    deoptimize otherwise.
    
    Bug: chromium:1112155,v8:10582
    Change-Id: I910ac1c0781ac8842fdbf272f9173b55b02923ba
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2354810
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69521}
    3551cac6
property-access-builder.cc 11.2 KB