• ishell@chromium.org's avatar
    [runtime] Merge redirected and non-redirected callback fields · 134ca75c
    ishell@chromium.org authored
    Namely:
     - AccessorInfo::getter and AccessorInfo::js_getter,
     - CallHandlerInfo::callback and CallHandlerInfo::js_callback.
    
    The redirected/non-redirected callback distinction is required only
    for simulated builds but we wasted memory also for all native builds.
    
    Now we store these fields in "redirected" form which allows us to call
    them directly from builtins or generated code. In case it's necessary
    to call a callback from C++ code the C function address is read from
    the redirection. This additional indirection makes the callback calls
    from C++ code in simulated builds slower but saves memory for native
    builds.
    
    This CL should recover a part of memory regression caused by inlining
    Foreign fields into AccessorInfo and CallHandlerInfo.
    
    Bug: v8:12949, chromium:1336105, chromium:1335930
    Change-Id: I38470ed21ee23b281247c11a9531542c7e4acca1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3835686Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Igor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82631}
    134ca75c
accessors.cc 32.5 KB