• Clemens Hammacher's avatar
    Revert "[inspector] introduced stackTraceId and externalAsyncTask API" · 4379533c
    Clemens Hammacher authored
    This reverts commit 3a41b697.
    
    Reason for revert: Break msvc: https://build.chromium.org/p/client.v8/builders/V8%20Win64%20-%20msvc/builds/250
    
    Original change's description:
    > [inspector] introduced stackTraceId and externalAsyncTask API
    > 
    > Sometimes we need to capture stack trace on one debugger and use it
    > later as a parent stack on another debugger (e.g. worker.postMessage).
    > 
    > This CL includes following addition to our protocol and v8-inspector.h:
    >   - added Runtime.StackTraceId, this id represents stack trace captured
    >     on debugger with given id,
    >   - protocol client can fetch Runtime.StackTrace by
    >     Runtime.StacKTraceId using Debugger.getStackTrace method,
    >   - externalParent field is added to Debugger.paused event, it may
    >     contain external parent stack trace,
    >   - V8Inspector::storeCurrentStackTrace captures current stack trace
    >     and returns V8StackTraceId for embedder this id can be used as
    >     argument for V8Inspector::externalAsyncTaskStarted and
    >     V8Inspector::externalAsyncTaskFinished method. Any async stack
    >     trace captured between these calls will get passed external stack
    >     trace as external parent. These methods are designed to be called
    >     on different debuggers. If async task is scheduled and started on
    >     one debugger user should continue to use asyncTask* API,
    >   - Debugger.enable methods returns unique debuggerId.
    > 
    > Bug: chromium:778796
    > Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    > Change-Id: I16aba0d04bfcea90f3e187e635a0588c92354539
    > Reviewed-on: https://chromium-review.googlesource.com/754183
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
    > Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#49582}
    
    TBR=dgozman@chromium.org,pfeldman@chromium.org,yangguo@chromium.org,kozyatinskiy@chromium.org,jgruber@chromium.org
    
    Change-Id: I9b52354fa0841e5148596cf594317f2e5fe508ea
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:778796
    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_chromium_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/786152Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49584}
    4379533c
v8-stack-trace-impl.cc 11.7 KB