• vogelheim's avatar
    Fix ExternalTwobyteStringUtf16CharacterStream::PushBack(kEndOfInput) · 57f0a521
    vogelheim authored
    PushBack(end-of-input) is a little weird, but since
    Utf16CharacterStream::Advance will advance pos_m, but not buffer_cursor_
    when at the end of the stream, pushing back the end-of-input token needs
    to do the exact inverse.
    
    (The reason Advance does not advance buffer_cursor_ is that buffer_cursor_ is often dereferenced
     directly to access memory and so always needs to point to, well, memory.)
    (The PushBack implementation for all other streams looks correct.)
    
    R=rossberg@chromium.org
    BUG=chromium:607903
    LOG=Y
    
    Review-Url: https://codereview.chromium.org/1941843002
    Cr-Commit-Position: refs/heads/master@{#35968}
    57f0a521
scanner-character-streams.h 5.76 KB