• Dan Elphick's avatar
    [snapshot] Fix mksnapshot with warmup script · 5c7e24d7
    Dan Elphick authored
    This fixes an assertion failure in mksnapshot that when the read-only
    space is created for a second time, that its checksum should match the
    first time it was deserialized. However with warmup scripts in
    mksnapshot, the first run through doesn't deserialize it, but creates it
    from scratch.  Then the next time through it deserializes it which it
    doesn't expect and so crashes as there is no checksum to compare it to.
    
    This fixes it by only checking if is a last_checksum (e.g. that it was
    deserialized). Additionally CHECK that we never attempt to create the
    objects from scratch if previously deserialized from a snapshot.
    
    Bug: v8:10320
    Change-Id: I598e5298b68f45911e20533db91d7f24fea21045
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2102579Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66718}
    5c7e24d7
read-only-heap.cc 6.68 KB