• Andreas Haas's avatar
    Reland "[wasm] Re-exported globals preserve their identity" · 1e4282db
    Andreas Haas authored
    This is a reland of f7a1932e
    
    There was a wpt test in Chrome that expected the incorrect behavior.
    I disable the test in https://crrev.com/c/2264418 so that we can land
    the fix here.
    
    Original change's description:
    > [wasm] Re-exported globals preserve their identity
    >
    > V8 fails a recently added spec test that when an imported global get
    > re-exported, it should preserve its identity. This CL fixes the behavior
    > in V8.
    >
    > Drive-by change: fix the object printer of globals: a global which
    > stores a reference type only has a tagged buffer, a global which stores
    > a value type only has an untagged buffer.
    >
    > R=clemensb@chromium.org
    >
    > Bug: v8:10556
    > Change-Id: I949d147fe4395610cfec6cf60082e1faecb23036
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2235702
    > Commit-Queue: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#68513}
    
    Bug: v8:10556
    Change-Id: I8e1b08fc9f72dde166cba167e6e320e714796769
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2264097Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68552}
    1e4282db
wasm-js.status 2.02 KB