• Benedikt Meurer's avatar
    [inspector][wasm] Remove obsolete Debugger.executeWasmEvaluator(). · 39645430
    Benedikt Meurer authored
    With https://crrev.com/c/2087396 we introduced a new CDP method
    `Debugger.executeWasmEvaluator()`, which we originally intended
    to use as the foundation for Debug-Evaluate on Wasm frames.
    
    However in the process of prototyping we learned that it is too
    costly and too inefficient to use WebAssembly modules here, and
    we switched to regular Debug-Evaluate with JavaScript instead
    (with a special debug proxy exposed that allows JavaScript to
    peak into the Wasm frame), since JavaScript is better suited
    for short-lived / short-running snippets and we don't need
    clang and wasm-ld then to generate these snippets.
    
    The JavaScript exposed debug proxy (as described in [1]) not
    only enables more powerful and flexible Debug-Evaluate for the
    DWARF C/C++ extension, but also serves as the basis for various
    aspects of the Basic Wasm Developer Experience.
    
    In order to pay down technical debt and to keep the maintenance
    overhead low, we should remove the initial prototype now, also
    to ensure that we don't accidentally attract other users of CDP
    to rely on this unsupported API (despite it being marked as
    "experimental").
    
    [1]: https://docs.google.com/document/d/1VZOJrU2VsqOZe3IUzbwQWQQSZwgGySsm5119Ust1gUA
    
    Fixed: chromium:1162062
    Bug: chromium:1020120, chromium:1068571, chromium:1127914
    Change-Id: I6dba8c906a8675ce6c29a52e3c32bb6626a27247
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2605186
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71882}
    39645430
debug-stack-trace-iterator.cc 7.39 KB