• bmeurer's avatar
    [builtins] Remove STRING_ADD_LEFT and STRING_ADD_RIGHT builtins. · d90a4047
    bmeurer authored
    These builtins present an optimization for the general addition case,
    where one side is already known to be a string. Unfortunately this
    optimization is wrong in the presence of @@toPrimitive (there are some
    ideas how to implement a similar optimization using the prototype
    backpointer mechanism that jkummerow@ introduced earlier). So this
    also removes the broken %_IsStringWrapperSafeForDefaultValueOf, which is
    the key part of the optimization mentioned above.
    
    R=mstarzinger@chromium.org
    BUG=v8:4307
    LOG=n
    
    Review URL: https://codereview.chromium.org/1336273002
    
    Cr-Commit-Position: refs/heads/master@{#30707}
    d90a4047
full-codegen-x87.cc 173 KB