• mstarzinger's avatar
    Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of... · 5977ed02
    mstarzinger authored
    Revert of Remove kind field from StackHandler. (patchset #4 id:60001 of https://codereview.chromium.org/1002203002/)
    
    Reason for revert:
    Layout test failure in inspector/sources/debugger/debugger-pause-on-promise-rejection.html
    
    Original issue's description:
    > Remove kind field from StackHandler.
    >
    > This makes the Isolate::Throw logic not depend on a prediction of
    > whether an exception is caught or uncaught. Such a prediction is
    > inherently undecidable because a finally block can decide between
    > consuming or re-throwing an exception depending on arbitray control
    > flow.
    >
    > There still is a conservative prediction mechanism in place that
    > components like the debugger or tracing can use for reporting.
    >
    > With this change we can get rid of the StackHandler::kind field, a
    > pre-requisite to do table-based lookups of exception handlers.
    >
    > R=yangguo@chromium.org
    >
    > Committed: https://crrev.com/96f79568a926966ebcf0685bf9adc947f4e1fbff
    > Cr-Commit-Position: refs/heads/master@{#27210}
    
    TBR=yangguo@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    
    Review URL: https://codereview.chromium.org/1009903002
    
    Cr-Commit-Position: refs/heads/master@{#27215}
    5977ed02
frames-inl.h 8.48 KB