• Peter Marshall's avatar
    [cleanup] Add a helper explicitly for BuiltinId functions in bootstrapper · 1e854443
    Peter Marshall authored
    - Remove the InstallFunction variant which just passed its arguments
      straight to JSObject::AddProperty
    - Change InstallFunction to accept a String rather than a Symbol as all
      symbol installation goes through InstallFunctionAtSymbol now. This way
      we can avoid the call to Name::ToFunctionName as well
    - Add an explicit helper InstallFunctionWithBuiltinId for installing
      functions which have a builtin ID. These are always installed with
      DONT_ENUM PropertyAttributes so we can remove that parameter, too.
    - Remove PropertyAttributes from InstallFunction because it is always
      DONT_ENUM.
    
    Bug: v8:8238
    Change-Id: I7af3d6d833d50065c20e198e21a72ef4a539c1ca
    Reviewed-on: https://chromium-review.googlesource.com/c/1349284Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#57789}
    1e854443
bootstrapper.cc 266 KB