• Georg Neis's avatar
    Reland "[turbofan] Fix bug in Number.Min/Max typings" · 898b8915
    Georg Neis authored
    This reverts commit f442b03f.
    
    Reason for reland: Wrongly reverted.
    
    Original change's description:
    > Revert "[turbofan] Fix bug in Number.Min/Max typings"
    > 
    > This reverts commit 4158af83.
    > 
    > Reason for revert: causing UBSAN failures:
    > 
    > https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/10729?
    > 
    > 
    > Original change's description:
    > > [turbofan] Fix bug in Number.Min/Max typings
    > > 
    > > They try to be very precise about when the result can be -0,
    > > but do so incorrectly. I'm changing the code to just do the
    > > simple thing instead. Let's see how that affects performance.
    > > 
    > > Bug: chromium:1072171
    > > Change-Id: I9737a84aa19d06685af5b7bca541e348dc37cca8
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157028
    > > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > > Commit-Queue: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#67246}
    > 
    > TBR=neis@chromium.org,tebbi@chromium.org
    > 
    > Change-Id: I0d9b312e27f5a8bbbebeccdc9819fa94f10af139
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: chromium:1072171
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157646
    > Reviewed-by: Francis McCabe <fgm@chromium.org>
    > Commit-Queue: Francis McCabe <fgm@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67249}
    
    TBR=neis@chromium.org,tebbi@chromium.org,fgm@chromium.org
    
    Change-Id: Ida36ca584a5af5da887189328c8da195b26285d4
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:1072171
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157368Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67263}
    898b8915
typer-unittest.cc 22.4 KB