• Leszek Swirski's avatar
    [ignition] Single-switch generator bytecode · c869d40d
    Leszek Swirski authored
    Currently, yields and awaits inside loops compile to bytecode which
    switches to the top of the loop header, and switch again once inside the
    loop. This is to make loops reducible.
    
    This replaces this switching logic with a single switch bytecode that
    directly jumps to the bytecode being resumed. Among other things, this
    allows us to no longer maintain the generator state after the switch at
    the top of the function, and avoid having to track loop suspend counts.
    
    TurboFan still needs to have reducible loops, so we now insert loop
    header switches during bytecode graph building, for suspends that are
    discovered to be inside loops during bytecode analysis. We do, however,
    do some environment magic across loop headers since we know that we will
    continue switching if and only if we reached that loop header via a
    generator resume. This allows us to generate fewer phis and tighten
    liveness.
    
    Change-Id: Id2720ce1d6955be9a48178322cc209b3a4b8d385
    Reviewed-on: https://chromium-review.googlesource.com/866734
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50804}
    c869d40d
bytecode-graph-builder.cc 132 KB