• Mircea Trofin's avatar
    Revert "Revert "[wasm] Consolidate function table representation."" · c2928fe4
    Mircea Trofin authored
    This reverts commit 862d605c.
    
    Reason for revert: fixed compile issue
    
    Original change's description:
    > Revert "[wasm] Consolidate function table representation."
    > 
    > This reverts commit 4a45f35f.
    > 
    > Reason for revert: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20debug%20builder/builds/25471 
    > 
    > Original change's description:
    > > [wasm] Consolidate function table representation.
    > > 
    > > This CL avoids the need to reference the function tables (and signatures)
    > > as either fixed arrays or vectors, preferring vectors.
    > > 
    > > The only place we need fixed arrays is on the compiled module, to support
    > > serialization. When we move off the GC heap, we'll also move away
    > > from fixed arrays in that last case.
    > > 
    > > The CL aids with getting wasm of the GC heap, by reducing the places 
    > > and representations we'll need to change  when changing the way we 
    > > reference fixed tables.
    > > 
    > > Bug: 
    > > Change-Id: Id4e43905a3df39062bf2839fa72dd5d9a0fe87da
    > > Reviewed-on: https://chromium-review.googlesource.com/588334
    > > Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
    > > Reviewed-by: Brad Nelson <bradnelson@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#46917}
    > 
    > TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    > 
    > Change-Id: Ie7d04f7ec74d6d0b3783df1c78c91c100ab784f4
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Reviewed-on: https://chromium-review.googlesource.com/588627
    > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#46918}
    
    TBR=bradnelson@chromium.org,titzer@chromium.org,mtrofin@chromium.org,ahaas@chromium.org
    
    Change-Id: Ic0ba8097c13f2b1afd263b6243360e8ab95ae474
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/588667
    Commit-Queue: Mircea Trofin <mtrofin@chromium.org>
    Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46919}
    c2928fe4
module-compiler.cc 96.4 KB