• Leszek Swirski's avatar
    [ast] Allocate cons strings in young space on main thread · 60f108f9
    Leszek Swirski authored
    In the case of function names, we allocate ConsStrings only to flatten
    them during finalization. Allocating these ConsStrings in old space
    appears to have regressed some benchmarks (especially memory benchmarks),
    but is necessary for off-thread allocation which doesn't have a young
    space.
    
    Ideally, we would avoid allocating these ConsStrings in the first place,
    and would flatten the data directly from the AstConsString. For now, we
    make them allocate in old space for off-thread allocation only, to
    revert the regressions. In the future we can investigate smarter
    flattening.
    
    Bug: chromium:1011762
    Bug: chromium:1044477, chromium:1044147, chromium:1043573, chromium:1043168
    Change-Id: If24b738d6f2eeb8c0fea042a711deb2a19015fbd
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2020948
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66025}
    60f108f9
ast-value-factory.cc 13.3 KB