-
Michael Achenbach authored
This reverts commit 46573e51. Reason for revert: Speculative revert for breaking chromium integration. Might break gpu tests and linux debug: https://ci.chromium.org/p/v8/builders/luci.v8.ci/Mac%20V8%20FYI%20Release%20(Intel)/2554 Also blocks the roll: https://chromium-review.googlesource.com/c/chromium/src/+/1234328 Original change's description: > [es2015] Introduce JSDataView::external_pointer. > > This adds a new external_pointer field to every JSDataView instance > which points directly into the backing store at the given view's > byte_offset. This was the DataView performance is now almost on > par with the TypedArray performance for accessing aligned memory > (with appropriate endianess). This also serves as prepatory work > to enable full 64-bit addressing of DataView backing stores in > optimized code (soonish). > > This change optimizes the bounds checking sequence in TurboFan in > such a way that it further improves the DataView set/get performance > by around 10%, almost closing the remaining gap between DataViews > and TypedArrays. > > Drive-by-fix: Get rid of the code duplication around DataView inlining > in the JSCallReducer and have only a single bottleneck method now. > > Bug: chromium:225811, v8:4153, v8:7881, v8:8171 > Change-Id: I9118efd4d19e93f0e51c931a9bec1a56a0f4593e > Reviewed-on: https://chromium-review.googlesource.com/1231994 > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org> > Reviewed-by: Tobias Tebbi <tebbi@chromium.org> > Reviewed-by: Yang Guo <yangguo@chromium.org> > Reviewed-by: Michael Lippautz <mlippautz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#56042} TBR=yangguo@chromium.org,mlippautz@chromium.org,tebbi@chromium.org,bmeurer@chromium.org Change-Id: I614a90043b1574b19936c37987db94806cac3bd7 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:225811, v8:4153, v8:7881, v8:8171 Reviewed-on: https://chromium-review.googlesource.com/1234417Reviewed-by: Michael Achenbach <machenbach@chromium.org> Commit-Queue: Michael Achenbach <machenbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#56059}
ec216398