• Seth Brenith's avatar
    [tools] Add list of classes to v8_debug_helper · 4d0360aa
    Seth Brenith authored
    This change extends v8_debug_helper to export a new method that returns
    a list of all known heap object types.
    
    Why? We can substantially improve the user experience in our work-in-
    progress WinDbg extension if we register handlers not only for
    v8::internal::Object but for every specific HeapObject type. This has
    two benefits:
    
    - You save a click: if you're expanding a local variable of a more
      specific type than Object, you can see properties immediately rather
      than first needing to expand a sub-item that casts the variable to
      Object.
    - You retain the type hint: GetObjectProperties accepts a type hint
      string, and it's super important to pass it when working in a crash
      dump because the object's Map is probably inaccessible. If we have to
      cast to Object first, we lose this data.
    
    Bug: v8:9376
    Change-Id: I4d635a1826574a3d08ac657e848e1fe7b83849fe
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1822859Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/master@{#64331}
    4d0360aa
BUILD.gn 2.43 KB