• Sigurd Schneider's avatar
    Revert "[embedded] Share a single RelocInfo between all trampolines" · bb54f999
    Sigurd Schneider authored
    This reverts commit 1bf6e735.
    
    Reason for revert: Breaks nosnap builds:
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Linux%20-%20nosnap%20-%20debug/21209
    
    Original change's description:
    > [embedded] Share a single RelocInfo between all trampolines
    > 
    > Creates a single RelocInfo to be used by all builtin trampolines and
    > stores it as a root. All trampolines then substitute this for their
    > trampoline at generation time with DCHECKs to make sure it is
    > identical.
    > 
    > Also forces all non-trampoline RelocInfo ByteArrays for builtins to be
    > generated into RO_SPACE.
    > 
    > On x64, this results in the OLD_SPACE part of the startup snapshot
    > decreasing in size from 166096 to 131248 (-34848) bytes and RO_SPACE
    > (in the read-only snapshot) increasing from 31176 to 31248 (+72) bytes.
    > 
    > Bug: v8:8295
    > Change-Id: I69f4a899b738f2023ed42501c2b9797d34305b06
    > Reviewed-on: https://chromium-review.googlesource.com/c/1276468
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#56811}
    
    TBR=ulan@chromium.org,jgruber@chromium.org,delphick@chromium.org
    
    Change-Id: I57239af6f3fc9c403977da0561b8fe32c1a758e7
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8295
    Reviewed-on: https://chromium-review.googlesource.com/c/1291070Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56814}
    bb54f999
builtins.h 8.33 KB