• Clemens Backes's avatar
    [traphandler] Fix ProbeMemory on Mac release builds · 936debb5
    Clemens Backes authored
    For some reason, the "ret" instruction goes missing on Mac release
    builds, probably because the compiler decides to split the inline
    assembly block and move the "v8_probe_memory_continuation" block
    somewhere else. This CL fixes that by adding another explicit "ret" at
    the end of "ProbeMemory".
    
    Also, we remove the "v8_probe_memory_address" symbol (which is identical
    to just "ProbeMemory"), to prevent the compiler from splitting
    "ProbeMemory" and "v8_probe_memory_address".
    
    R=ahaas@chromium.org
    
    Bug: v8:11955
    Change-Id: I2e63b2db94206e329be214ab7b553ab502d6ecc2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3071202Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76091}
    936debb5
handler-inside-posix.cc 6.67 KB