• Aleksey Kozyatinskiy's avatar
    [inspector] moved var initialization break location before init expression (reland) · fb6a094d
    Aleksey Kozyatinskiy authored
    This CL improves break locations for expressions like 'var a = <expr>'. Without CL we use <expr> position as break location for initialization statement, with this CL we use position of first character after '=' as position.
    Benefits (see test for details):
     - only one break in expressions which includes mix of property lookup and calls, e.g. var p = Promise.resolve().then(x => x * 2),
     - removed redundant break location for expressions like: let { x, y } = { x: 1, y: 2}.
     
    TBR=dgozman@chromium.org,rmcilroy@chromium.org,machenbach@chromium.org,marja@chromium.org,kozyatinskiy@chromium.org,devtools-reviews@chromium.org,v8-reviews@googlegroups.com
    # Not skipping CQ checks because original CL landed > 1 day ago.
    Bug: v8:5909
    
    Change-Id: Ie84fa79afeed09e28cf8478ba610a0cfbfdfc294
    Reviewed-on: https://chromium-review.googlesource.com/518116
    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Reviewed-by: 's avatarAleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45598}
    fb6a094d
parser.h 47.8 KB