• Dan Elphick's avatar
    [build] Reduce size of inline header cycles · c26965bd
    Dan Elphick authored
    This removes/replaces header includes with the aim of shrinking the
    size of the inline header cycle. Specifically before this CL, there was
    a single Strongly-Connected Component comprising 60 header files from
    src/objects and src/heap.
    
    Now there are two 2 SCCs. The src/heap SCC has 6 files and depends on
    the src/objects SCC, which has 50 files. Additionally some previously
    implicit dependencies have been added.
    
    Dependencies calculated using:
    git grep "#include \"" *.h *.cc | sed 's/:#include "/ /;s/".*$//' | \
    awk 'BEGIN {print "digraph deps {" } END {print "}"} {print "\""$1"\" -> \""$2"\""}'
    
    SCCs found using sccmap from graphviz.
    
    Also removes unused Cell::FromValueAddress method.
    
    Change-Id: Ib19d00ccd14e490ee64d57be4d99b1b3686ac32a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2951734Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Dan Elphick <delphick@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75103}
    c26965bd
string.cc 58.7 KB