• Maya Lekova's avatar
    Revert "[sparkplug] Change bytecode offset mapping and introduce iterator." · 6fa780ff
    Maya Lekova authored
    This reverts commit a8b61ef5.
    
    Reason for revert: Looks like it breaks GC stress bot - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/35880/overview
    
    Original change's description:
    > [sparkplug] Change bytecode offset mapping and introduce iterator.
    >
    > Previously, we recorded pairs of (bytecode offset, sparkplug pc) to
    > create a mapping of bytecode offset <-> sparkplug pc.
    > These pairs were only recorded after builtin/runtime calls.
    > In preparation for deoptimizing to Sparkplug, we need a more precise
    > mapping.
    > With this CL, we record positions for every bytecode. Instead of storing
    > a pair of (bytecode offset, sparkplug pc), we store only the pc,
    > calculating the bytecode offset from the index in the mapping table.
    > For easier use an iterator to access the mapping is introduced.
    >
    > Drive-by: Reduce sampling interval in cpu-profiler cctest to get rid of
    > flaky failures.
    >
    > Bug: v8:11420, v8:11429
    > Change-Id: I36a9171f43a574eb67880cbca6cf9ff7ab291e60
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2720189
    > Reviewed-by: Victor Gomes <victorgomes@chromium.org>
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Auto-Submit: Patrick Thier <pthier@chromium.org>
    > Commit-Queue: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#73186}
    
    Bug: v8:11420
    Bug: v8:11429
    Change-Id: Ie71e7ce234e7b9ab9a2ec99a983e9900f35baa44
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2735397
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#73187}
    6fa780ff
DEPS 2.21 KB