• Seth Brenith's avatar
    Revert "[torque][cleanup] Use more precise field types in a few classes" · 16cb2d94
    Seth Brenith authored
    This reverts commit 4e5fabae.
    
    Reason for revert: performance regressions chromium:1085305, chromium:1084978
    
    Original change's description:
    > [torque][cleanup] Use more precise field types in a few classes
    > 
    > This change updates some Torque-defined classes to include more precise
    > field types where possible. It also updates those classes to use
    > @generateCppClass. One field was removed because it's unused
    > (PrototypeInfo::validity_cell), and two fields in StackFrameInfo
    > actually became less precise because they're based on Script::name,
    > which is an embedder-provided untyped Local<Value>. (Automatically
    > generated accessors pointed out this bug easily.)
    > 
    > This change also includes a couple of minor fixes in Torque.
    > 
    > Change-Id: Ib2bc6c7165bb3612b6d344c0686a94165a568277
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2199640
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67907}
    
    TBR=ulan@chromium.org,tebbi@chromium.org,verwaest@chromium.org,seth.brenith@microsoft.com
    
    Change-Id: I720821d8dc84ea0d79eb137f1c2507f75df9a107
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2211322Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67972}
    16cb2d94
heap-snapshot-generator.cc 102 KB