• Seth Brenith's avatar
    Revert "Shorten generated code for binary-search switches" · c84bcd74
    Seth Brenith authored
    This reverts commit 00a757fa.
    
    Reason for revert: Caused perf regressions, https://crbug.com/1280236
    
    Original change's description:
    > Shorten generated code for binary-search switches
    >
    > On some branches of the search tree for a binary-search switch, the
    > input value is sufficiently constrained that we could unconditionally
    > jump to the last possible case rather than checking for value equality.
    > This shortens some builtins by a few instructions and might speed things
    > up, though I expect the effect to be small.
    >
    > Change-Id: I2313f26976e6d3c182f03bd927b338c8175b3af3
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3335437
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    > Cr-Commit-Position: refs/heads/main@{#78376}
    
    Bug: chromium:1280236
    Change-Id: I88d9ff64641b85d48198b7012df2eeb9441913b5
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3343234
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Cr-Commit-Position: refs/heads/main@{#78397}
    c84bcd74
code-generator.cc 53.2 KB