• Sigurd Schneider's avatar
    Speculatively revert "[turboassembler] Introduce hard-abort mode" · 039c18e1
    Sigurd Schneider authored
    This reverts commit a462a785.
    
    Reason for revert: Breaks a TurboAssembler test:
    https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Arm/7726
    
    Original change's description:
    > [turboassembler] Introduce hard-abort mode
    > 
    > For checks and assertions (mostly for debug code, like stack alignment
    > or zero extension), we had two modes: Emit a call to the {Abort}
    > runtime function (the default), and emit a debug break (used for
    > testing, enabled via --trap-on-abort).
    > In wasm, where we cannot just call a runtime function because code must
    > be isolate independent, we always used the trap-on-abort behaviour.
    > This causes problems for our fuzzers, which do not catch SIGTRAP, and
    > hence do not detect debug code failures.
    > 
    > This CL introduces a third mode ("hard abort"), which calls a C
    > function via {ExternalReference}. The C function still outputs the
    > abort reason, but does not print the stack trace. It then aborts via
    > "OS::Abort", just like the runtime function.
    > This will allow fuzzers to detect the crash and even find a nice error
    > message.
    > 
    > Even though this looks like a lot of code churn, it is actually not.
    > Most added lines are new tests, and other changes are minimal.
    > 
    > R=​mstarzinger@chromium.org
    > 
    > Bug: chromium:863799
    > Change-Id: I77c58ff72db552d49014614436259ccfb49ba87b
    > Reviewed-on: https://chromium-review.googlesource.com/1142163
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Reviewed-by: Michael Starzinger <mstarzinger@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#54592}
    
    TBR=mstarzinger@chromium.org,clemensh@chromium.org
    
    Change-Id: I60c011cfe262ccebbb9abf32699a9fe17e72a3c8
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: chromium:863799
    Reviewed-on: https://chromium-review.googlesource.com/1145431
    Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    Reviewed-by: 's avatarSigurd Schneider <sigurds@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54597}
    039c18e1
external-reference.h 16.9 KB