• mvstanton's avatar
    [TypeFeedbackVector] Root literal arrays in function literals slots · 93df0940
    mvstanton authored
    Literal arrays and feedback vectors for a function can be garbage
    collected if we don't have a rooted closure for the function, which
    happens often. It's expensive to come back from this (recreating
    boilerplates and gathering feedback again), and the cost is
    disproportionate if the function was inlined into optimized code.
    
    To guard against losing these arrays when we need them, we'll now
    create literal arrays when creating the feedback vector for the outer
    closure, and root them strongly in that vector.
    
    BUG=v8:5456
    
    Review-Url: https://codereview.chromium.org/2504153002
    Cr-Commit-Position: refs/heads/master@{#41893}
    93df0940
bytecode-generator.cc 124 KB