• Ng Zhi An's avatar
    Reland "[wasm-simd][liftoff] Fix I64x2Mul" · 1495b3db
    Ng Zhi An authored
    This relands commit 76debfda.
    
    This fix here is to convert the original mjsunit test into a
    cctest, where we check for SIMD support, and skip the test.
    We don't have lowering for I64x2 yet, so this is the
    workaround.
    
    Original change's description:
    > [wasm-simd][liftoff] Fix I64x2Mul
    >
    > The I64x2Mul overwrote the lhs/rhs if they are the same as dst. So when
    > deciding if we need temporaries, we should not only check the
    > cache_state, but whether they alias dst or not.
    >
    > Bug: chromium:1088273
    > Change-Id: I82efa9b45e0a3d321a06efde60971ce95b21490f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2225796
    > Commit-Queue: Zhi An Ng <zhin@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#68114}
    
    Bug: chromium:1088273
    Change-Id: Ia3fd251998159d9beb581a6af3414921fe968e40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2227068
    Commit-Queue: Zhi An Ng <zhin@chromium.org>
    Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#68159}
    1495b3db
test-run-wasm-simd-liftoff.cc 3.98 KB