• Jakob Gruber's avatar
    [nci] Check for NCI code in the CompileLazy builtin · 49ec5c4c
    Jakob Gruber authored
    This CL fixes a spot (pointed out by Mythri) in which it was possible
    to start running unoptimized bytecode even if cached NCI code was
    present.
    
    Previously, the CompileLazy builtin would skip the runtime and start
    running bytecode immediately if the SharedFunctionInfo was already
    compiled; any NCI code was ignored.
    
    This CL changes the CompileLazy builtin to additionally check the
    SFI::may_have_cached_code bit. If set, call into the (new) function
    Runtime::kTryInstallNCICode to try and install NCI code.
    
    Bug: v8:8888
    Change-Id: Icbee9f0780f9b65e9339f1a958f5b28abe42c810
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2546680Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71255}
    49ec5c4c
builtins-lazy-gen.cc 7.54 KB