• Francis McCabe's avatar
    Revert "Reland^2 "[parser] Introduce UnoptimizedCompileFlags"" · b89397c5
    Francis McCabe authored
    This reverts commit 0a59e0cb.
    
    Reason for revert: Still causing UBSAN issues:
    
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20UBSan/10729
    
    
    Original change's description:
    > Reland^2 "[parser] Introduce UnoptimizedCompileFlags"
    > 
    > This is a reland of d91679bf
    > which was a reland of d91679bf
    > 
    > Fixes missing initialization of ParserBase::allow_eval_cache_
    > 
    > Original change's description:
    > > [parser] Introduce UnoptimizedCompileFlags
    > >
    > > UnoptimizedCompileFlags defines the input flags shared between parse and
    > > compile (currently parse-only). It is set initially with some values, and
    > > is immutable after being passed to ParseInfo (ParseInfo still has getters
    > > for the fields, but no setters).
    > >
    > > Since a few of the existing flags were output flags, ParseInfo now has a
    > > new output_flags field, which will eventually migrate to a ParseOutputs
    > > structure.
    > >
    > > Bug: v8:10314
    > > Change-Id: If3890a5fad883bca80a97bf9dfe44d91797dc286
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2096580
    > > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > > Reviewed-by: Simon Zünd <szuend@chromium.org>
    > > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#66782}
    > 
    > TBR=rmcilroy@chromium.org,ulan@chromium.org,szuend@chromium.org
    > 
    > Bug: v8:10314
    > Change-Id: I470de963bdedad31fe7dd149c610f9a89bffa162
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157030
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#67245}
    
    TBR=rmcilroy@chromium.org,leszeks@chromium.org
    
    Change-Id: I1c5f58cc5608217a149b04aa6f50bb3d7606c26d
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:10314
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157657Reviewed-by: 's avatarFrancis McCabe <fgm@chromium.org>
    Commit-Queue: Francis McCabe <fgm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67250}
    b89397c5
preparser.cc 15.1 KB