• Milad Fa's avatar
    s390: Revert "[wasm-simd] Canonicalize shuffles when creating TurboFan graph" · b681c309
    Milad Fa authored
    Port ede5e814
    
    Original Commit Message:
    
        This reverts commit d16eefe0.
    
        It is not correct to check for node equality during the graph
        construction phase, because we can have optimizations that will combine
        same nodes. So it can happen that in wasm-compiler, the inputs to
        shuffle are not the same, so we canonicalize using that knowledge that
        it will not be the same, and allow indices > 15. But later we can have
        optimizations that combine the 2 inputs (e.g. splat of the same
        constants), and the instruction selector will see that the input nodes
        are the same.
    
    R=zhin@chromium.org, joransiu@ca.ibm.com, junyan@redhat.com, midawson@redhat.com
    BUG=
    LOG=N
    
    Change-Id: I0d388c814dc1c45f978d749218b8120bfd53bb03
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2835397Reviewed-by: 's avatarJunliang Yan <junyan@redhat.com>
    Commit-Queue: Milad Fa <mfarazma@redhat.com>
    Cr-Commit-Position: refs/heads/master@{#74042}
    b681c309
instruction-selector-s390.cc 111 KB