• Simon Zünd's avatar
    Calls to {console} require an access check for the provided arguments · a5fd60e1
    Simon Zünd authored
    This CL adds an access check for the arguments to all calls to
    {console} like {console.log}. This is needed since the DevTools
    protocol notificiation event does not contain the context in which
    the {console.log} call occurred. Only the context of the argument.
    When DevTools then reads properties for the preview of the argument,
    it uses arguments context, instead of the calling context, potentially
    leaking objects/exceptions into the calling context.
    
    Bug: chromium:987502, chromium:986393
    Change-Id: I6f7682f7bee94a28ac61994bad259bd003511c39
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741664
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63122}
    a5fd60e1
access-check-unittest.cc 8.65 KB