• Shu-yu Guo's avatar
    Revert "[ptr-cage] Better support sharing CodeRange with re-embedded builtins" · 8613ac24
    Shu-yu Guo authored
    This reverts commit a61aa491.
    
    Reason for revert: Did not fix the original issue with chromium
    tests toggling jitless mode after V8 has already been initialized
    on Win64.
    
    Original change's description:
    > [ptr-cage] Better support sharing CodeRange with re-embedded builtins
    >
    > If a shared CodeRange is already allocated when creating an Isolate in
    > jitless mode, the CodeRange will be used. This is to better support the
    > following use pattern:
    >
    > ```
    > FLAG_jitless = false;
    > v8::Isolate::New();
    > FLAG_jitless = true;
    > v8::Isolate::New();
    > ```
    >
    > Note that the other direction of toggling jitless from true to false is
    > unsupported and may have undefined behavior.
    >
    > Bug: v8:11460
    > Change-Id: I1c451c53bc160be4122056d8b309323a94d4b8b6
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2890591
    > Commit-Queue: Shu-yu Guo <syg@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#74535}
    
    TBR=ishell@chromium.org
    
    Bug: v8:11460
    Change-Id: I0acd7d0d444efbf6b9860bcc5e91034319b78601
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2893827Reviewed-by: 's avatarShu-yu Guo <syg@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/master@{#74559}
    8613ac24
test-ptr-compr-cage.cc 5.66 KB