• Camillo Bruni's avatar
    [d8] Disable d8.promise.setHooks with correctness fuzzing · 060c2cb1
    Camillo Bruni authored
    Setting promise hooks after running some promise-related code has hard
    to control side-effects that make correctness fuzzing difficult.
    
    Certain Promise functions are optimized and avoid creating intermediate
    Promises. Dynamically enabled Promise hooks combined with --force-slow-path,
    which would cause us to always create those intermediate Promises, will
    get us very differet callbacks if the hooks are enabled half-way.
    
    The exepected usage pattern is to only use setHooks if there are no
    pending promises, something that cannot be guaranteed for fuzzing.
    
    Bug: chromium:1202465
    Change-Id: Ifa96f2db9c441b6f5da696b88a1c087160ec8eeb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3013355Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75637}
    060c2cb1
d8.cc 188 KB