• Mythri Alle's avatar
    Revert "[turboprop] Pass required parameters as value inputs to TierUpCheck node" · b72c32c0
    Mythri Alle authored
    This reverts commit 44f46def.
    
    Reason for revert: Causes failure in  linux 64 fyi bots.
    https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20-%20fyi/18646?
    
    Original change's description:
    > [turboprop] Pass required parameters as value inputs to TierUpCheck node
    >
    > TierUpCheck node tail calls interpreter entry trampoline when additional
    > processing is needed for tiering up. Calling IET requires target,
    > new_target, input count and context as parameters. Earlier these were
    > created as parameter nodes in effect-control-linearizer. This causes
    > problems with Turboprop since TurboProp doesn't use the second scheduler
    > and cannot reschedule these nodes to the start block. We should instead
    > create these parameter nodes in bytecode-graph-builder and pass them
    > as value inputs to TierUpCheck node.
    >
    > Bug: v8:9684
    > Change-Id: Icfe5a33b4e628d5a3ba9a3121b2b0746be6aed5c
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2498695
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70790}
    
    TBR=rmcilroy@chromium.org,mythria@chromium.org,jgruber@chromium.org
    
    Change-Id: I66cd8a90efb39378c99e18f35548a1490b5e413a
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:9684
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2501846Reviewed-by: 's avatarMythri Alle <mythria@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70794}
    b72c32c0
bytecode-graph-builder.cc 177 KB