• Georg Neis's avatar
    Revert "Reland^3 "[turbofan] Use feedback when reducing global loads/stores."" · 073063d7
    Georg Neis authored
    This reverts commit 8683116e.
    
    Reason for revert: There's a bug in the StoreGlobalIC that causes regressions in combination with this CL (observable in Chrome but
    not in d8).
    
    Original change's description:
    > Reland^3 "[turbofan] Use feedback when reducing global loads/stores."
    >
    > This is a reland of 2d2c1374 without
    > changes. Offending chromium tests have been modified.
    >
    > Original change's description:
    > > Reland^2 "[turbofan] Use feedback when reducing global loads/stores."
    > >
    > > This reverts commit ac85ab0a. A
    > > chromium test caused trouble and was taken care of in
    > > https://chromium-review.googlesource.com/c/1384064.
    > >
    > > Original change's description:
    > > > [turbofan] Use feedback when reducing global loads/stores.
    > > >
    > > > We already record the script context location or the property cell
    > > > as feedback of the global load/store IC, so Turbofan doesn't need
    > > > to do the lookups again.
    > >
    > > TBR=sigurds@chromium.org
    > >
    > > Change-Id: I58bcd9bceec2f9cf401f7b0fc4460a6da6cd0abc
    > > Reviewed-on: https://chromium-review.googlesource.com/c/1386404
    > > Commit-Queue: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#58393}
    >
    > Change-Id: Ic6734201a6c45f2752488ab44b16859776802f51
    > Reviewed-on: https://chromium-review.googlesource.com/c/1408252
    > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > Commit-Queue: Georg Neis <neis@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#58769}
    
    TBR=neis@chromium.org,sigurds@chromium.org,bmeurer@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: chromium:922545, chromium:922514, chromium:922558
    Change-Id: I6e4c4c0fbc29a0f2a03972f1687242ae247ebfa8
    Reviewed-on: https://chromium-review.googlesource.com/c/1417614
    Commit-Queue: Georg Neis <neis@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#58891}
    073063d7
feedback-vector.cc 47.8 KB