• Aseem Garg's avatar
    Revert "[wasm] Reland "[wasm] redirect wasm calls to js functions through a GCed table"" · aee1e1fb
    Aseem Garg authored
    This reverts commit 649b1e70.
    
    Reason for revert: A1 Jetstream bots are still failing.
    
    Original change's description:
    > [wasm] Reland "[wasm] redirect wasm calls to js functions through a GCed table"
    >
    > This reverts commit 25f03308.
    >
    > Reason for revert: Fix the cause of bot failure and reland
    >
    > Original change's description:
    > > Revert "[wasm] redirect wasm calls to js functions through a GCed table"
    > >
    > > This reverts commit eb65f35e.
    > >
    > > Reason for revert: Broke jetstream benchmark on android.
    > >
    > > BUG=chromium:750828
    > >
    > > Original change's description:
    > > > [wasm] redirect wasm calls to js functions through a GCed table
    > > >
    > > > With this patch, rather than embedding the JSReceiver address directly
    > > > in the WasmToJS wrappers, we put that in a fixed array with global handle
    > > > scope and instead embed the location of the handle and the index in the
    > > > wrapper. This ensures that the wrapper doesn't need to be patched if the
    > > > GC kicks in. This is needed to get the WASM code off the GCed heap.
    > > >
    > > > R=​mtrofin@chromium.org
    > > >
    > > > Bug:
    > > > Change-Id: Ie5a77a78cdecec51b04f702c63b8e4285e6a2d8d
    > > > Reviewed-on: https://chromium-review.googlesource.com/581682
    > > > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    > > > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > > > Cr-Commit-Position: refs/heads/master@{#46884}
    > >
    > > TBR=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org
    > >
    > > # Not skipping CQ checks because original CL landed > 1 day ago.
    > >
    > > Change-Id: I26f49ee0a1fe73cc5d8852ded87b56638be39ebf
    > > Reviewed-on: https://chromium-review.googlesource.com/596268
    > > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    > > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#47059}
    >
    > R=​mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org,sullivan@chromium.org
    >
    > Change-Id: I29ef35f6e612a706d9f571da3e7beb1da8b5052b
    > Bug: chromium:750828
    > Reviewed-on: https://chromium-review.googlesource.com/597010
    > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    > Reviewed-by: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#47177}
    
    TBR=bradnelson@chromium.org,sullivan@chromium.org,mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org
    
    Bug: chromium:750828
    Change-Id: I04b12c0eb0705ad809822a7d7461423be77d942a
    Reviewed-on: https://chromium-review.googlesource.com/606867
    Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    Reviewed-by: 's avatarAseem Garg <aseemgarg@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47231}
    aee1e1fb
test-wasm-stack.cc 6.45 KB