• jgruber's avatar
    [builtins] Fix argument order inconsistency in HasProperty · 3c1f40de
    jgruber authored
    The HasProperty builtin differed in its expected argument order from
    the HasProperty runtime function. Like all other related spec
    primitives (e.g.: GetProperty, SetProperty, DeleteProperty), it should
    take {object} as the first argument and {key} as the second.
    
    This CL changes the builtin and all related spots to use the correct
    order.
    
    There was also a tricky bug in interpreter intrinsic rewriting, which
    assumes (but does not verify) that the argument order between runtime
    function and builtin is identical. Besides cctests, HasProperty
    intrinsic rewriting seems to be dead code.
    
    Bug: v8:8036
    Change-Id: Ia669fd6f5c73a30df4e4607064603be759ced392
    Reviewed-on: https://chromium-review.googlesource.com/1167297
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarMichael Stanton <mvstanton@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55022}
    3c1f40de
bytecode-graph-builder.h 17.9 KB