-
George Wort authored
The frame construction code in AssembleConstructFrame saves the registers on the stack, if this does not occur for every code path then the values restored to the registers in AssembleReturn will be incorrect. The relevant DCHECK had been removed here: https://chromium-review.googlesource.com/c/v8/v8/+/2922604/5/src/compiler/pipeline.cc. This was not previously an issue as no builtins used callee saved registers, this changed in the following patches: https://chromium-review.googlesource.com/c/v8/v8/+/2922604/ https://chromium-review.googlesource.com/c/v8/v8/+/2944844 Bug was found using PGO for the RecordWriteOmitRememberedSetSaveFP builtin on AArch64. Change-Id: I23fbea9f39c9b61ef0d0b28b73ebe6063e478fef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3401589Reviewed-by: Camillo Bruni <cbruni@chromium.org> Reviewed-by: Tobias Tebbi <tebbi@chromium.org> Commit-Queue: Martyn Capewell <martyn.capewell@arm.com> Cr-Commit-Position: refs/heads/main@{#78725}
61cc0cc5