• Benedikt Meurer's avatar
    [debug] Disallow LiveEdit of active frames. · 53fc4807
    Benedikt Meurer authored
    Previously we'd allow to replace the source of functions that are on the
    current execution stack under certain conditions, but this has resulted
    in an endless stream of bugs due to weird edge cases, and so we're now
    limiting LiveEdit to functions that don't have any activation (including
    not a suspended generator / async function activation).
    
    We might eventually add the ability to LiveEdit functions with
    activations and have them "upgrade upon next invocation", but that
    doesn't seem to be an extremely important use case right now.
    
    Fixed: chromium:1195927
    Change-Id: I87a45ba4d0ddcfbf867bd4e73738d76b2d789e04
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2846892
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74249}
    53fc4807
debug-interface.h 20.1 KB