• Maksim Sadym's avatar
    Add `WebDriverBiDi` serialization to CDP · a913a75b
    Maksim Sadym authored
    1. Added `generateWebDriverValue` flag to `Runtime.evaluate` and `Runtime.callFunctionOn`.
    2. Added `webDriverValue` field to `RemoteObject`, and set it in case of the `generateWebDriverValue` flag was set.
    3. Added virtual method `bidiSerialize` to allow embedder-implemented serialization (like in https://crrev.com/c/3472491).
    4. Implemented V8 serialization in a separate class `V8WebDriverSerializer`.
    5. Hardcode `max_depth=1`.
    6. Added tests.
    
    Not implemented yet:
    1. `objectId`.
    2. Test of embedder-implemented serialization.
    
    Tested automatically by:
    ```
    python3 tools/run-tests.py --outdir out/foo inspector/runtime/add-web-driver-value
    ```
    
    Naming to be discussed. Suggestions are very welcome.
    
    Design doc: http://go/bidi-serialization
    
    Change-Id: Ib35ed8ff58e40b3304423cc2139050136d844e2c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472077Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Commit-Queue: Maksim Sadym <sadym@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79922}
    a913a75b
v8-runtime-agent-impl.cc 39.6 KB