• Clemens Backes's avatar
    Reland "[wasm][inspector][test] Add more tests for code offsets" · 0f1c81d1
    Clemens Backes authored
    This is a reland of 4719dae1.
    The "V8 Linux64 TSAN - stress-incremental-marking" bot adds the
    --stress-incremental-marking flag for all variants, hence the SKIP in
    the status file was not triggered. We just explicitly disable the
    --stress-incremental-marking flag for the two new tests. This works for
    the "stress_incremental_marking" variant as well as the specific bot.
    
    Original change's description:
    > [wasm][inspector][test] Add more tests for code offsets
    >
    > The code offsets are sometimes wrong when compiled with streaming
    > compilation. Thus add more tests for synchronous, asynchronous, and
    > streaming compilation. The reported code offsets should all match. This
    > will be fixed in a follow-up CL.
    >
    > In order to make asynchronous WebAssembly compilation finish, the
    > inspector-test executable needs to pump the message loop before waiting
    > for new tasks to come in, just as other executables like d8.
    > This is added in this CL, but because of another bug this is skipped in
    > the stress-incremental-marking variant. Hence the new tests are also
    > skipped there.
    >
    > R=szuend@chromium.org
    > CC=ahaas@chromium.org
    >
    > Bug: chromium:1150303, v8:10748
    > Change-Id: Ie1d63c8d6795e61627d838b7fa7b21e6728befc0
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2562382
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#71483}
    
    Bug: chromium:1150303
    Bug: v8:10748
    Change-Id: I9adb9fc0250fab5c43dc85b695f4d338a9c7183c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2565128Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71492}
    0f1c81d1
task-runner.cc 4.24 KB