• Clemens Hammacher's avatar
    [wasm] Generate a more serial effect chain · ad55d888
    Clemens Hammacher authored
    Put all loads on the effect chain. This removes freedom of the
    scheduler, which might regress performance of the generated code
    (probably negligible) and might improve performance of code generation.
    It also prevents hard to diagnose bugs where the scheduler might
    schedule loads too early such that we miss an update during a function
    call or gc.
    
    In order to make all updates and uses of the "current control" and
    "current effect" more visible, this CL also introduces {SetEffect} and
    {SetControl} methods, and uses {Effect} and {Control} more rigorously.
    
    R=mstarzinger@chromium.org
    
    Change-Id: I917ce1775345a1fadf6166022c8848e36e195c56
    Reviewed-on: https://chromium-review.googlesource.com/1129235
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#54679}
    ad55d888
wasm-compiler.h 20.1 KB