• Maya Lekova's avatar
    Revert "Reland "[compiler] Don't collect source positions for the top frame"" · 9dff517a
    Maya Lekova authored
    This reverts commit f2e65226.
    
    Reason for revert: Speculative revert, seems to break GC stress bot and block LKGR - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/25701
    
    Original change's description:
    > Reland "[compiler] Don't collect source positions for the top frame"
    > 
    > Fixed crashes by adding missing call to EnsureSourcePositionsAvailable,
    > which requires clearing and restoring the pending exception.
    > 
    > > While most source positions were not collected even throwing exceptions,
    > > the top frame still was always collected as it was used to initialize
    > > the JSMessageObject. This skips even that frame, by storing the
    > > SharedFunctionInfo and bytecode offset in the JSMessageObject allowing
    > > it to lazily evaluate the actual source position.
    > >
    > > Also adds tests to test-api.cc that test each of the source position
    > > functions in isolation to ensure that they don't rely on previous
    > > invocations to call the source collection function.
    > >
    > > Since no source positions are now collected at the point when an
    > > exception is thrown, the mjsunit/stack-traces-overflow now passes again
    > > with the flag enabled. (cctest/test-cpu-profiler/Inlining2 is now the
    > > only failure).
    > 
    > Bug: v8:8510
    > Change-Id: Ifa5fe31d3db34a6c6d6a9cef3d646ad620dabd81
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1601270
    > Commit-Queue: Dan Elphick <delphick@chromium.org>
    > Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#61372}
    
    TBR=ulan@chromium.org,rmcilroy@chromium.org,delphick@chromium.org
    
    Change-Id: Ie590df6c308b38836afc5d417d03d2a63260bcb2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:8510
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1602692Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61381}
    9dff517a
messages.cc 46 KB